New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using 'import' as function name in internal interfaces. #11237

Merged

kronbichler merged 1 commit into dealii:master from bangerth:import-2

Nov 24, 2020

Member

bangerth commented Nov 24, 2020

See #11234 . These are functions in an internal namespace, so there should be no problem with renaming them.

/rebuild


          Avoid using 'import' as function name in internal interfaces.

8016a3c

bangerth added the ready to test label

masterleinad approved these changes

View reviewed changes

Member

masterleinad left a comment

I don't really see a need for this as of now but it also doesn't hurt.

kronbichler approved these changes

View reviewed changes

kronbichler merged commit 955ad96 into dealii:master

bangerth deleted the import-2 branch

November 25, 2020 01:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment