consistently use local_size() #11487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
implement-local_size_2
branch
from
6859484
to
92783a8
Compare
|
/rebuild |
kronbichler
approved these changes
Feb 3, 2021
|
You'll have to rebase because of a merge conflict. |
|
I'm all for this, but I had comments on #10335 that were not addressed there and consequently are not either here. Can we still put those fixes in before merging? |
This is the name given to the function by la_parallel_vector. Defining this everywhere gives us a true check as to whether or not a vector is distributed - i.e., if size() != local_size() then the vector is distributed and otherwise it is not.
masterleinad
force-pushed
the
implement-local_size_2
branch
from
92783a8
to
4a79418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revives #10335 based on #11472.