Move the get_*mapping() functions into ReferenceCell::Type. #11604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
force-pushed
the
ref-cell-9
branch
2 times, most recently
from
f81c91e
to
1c9bf90
Compare
peterrum
approved these changes
Jan 22, 2021
bangerth
force-pushed
the
ref-cell-9
branch
2 times, most recently
from
54e8254
to
5e7731e
Compare
|
This isn't ready yet. I keep discovering more places that need to be converted, and the Windows builds fail as well (with what looks like a MSVC bug). I'll ask for another review when it tests ok. |
bangerth
force-pushed
the
ref-cell-9
branch
3 times, most recently
from
632e5c8
to
e79ac1c
Compare
|
It finally works! Halleluyah! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #11544. Moving more free functions into the class. This one was a bit of a nuisance because of all of the changes to be made elsewhere, but it was worth it.
/rebuild