-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate DoFTools::extract_boundary_dofs() with std::vector<bool> argument #11995
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
Oh, I fix this place in #11996. Maybe I should just combine these two patches -- so done. Merging this patch is then also going to close #11996. That would also mean that if someone approved #11996, and since we already have two approvals for this PR here in its previous state, that the now combined patch here should be acceptable. |
I've removed the "Reviewed and ready to merge" label because I guess that you want to squash some of these commits, @bangerth? |
While there also update the documentation of its replacement a bit.
…irectly. We want to move away from these kinds of functions, so deprecate it and replace it by a function that does the right thing instead.
I reduced the number of commits a bit, but what I have now is pretty self-contained in each commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
We have slowly been replacing these by functions using
IndexSet
instead, and indeed such a function already exists. The function here is not particularly widely used./rebuild