Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add readability-implicit-bool-conversion #12265

Merged
merged 2 commits into from Jan 11, 2022
Merged

Add readability-implicit-bool-conversion #12265

merged 2 commits into from Jan 11, 2022

Conversation

masterleinad
Copy link
Member

Similar to #12262 let's just make clang-tidy also check for int->bool conversions.

@bangerth
Copy link
Member

Unsurprisingly, this triggers hundreds of warnings :-)

@masterleinad
Copy link
Member Author

Unsurprisingly, this triggers hundreds of warnings :-)

Yes, I rather wanted to quickly see. Where we are at. Obviously, also not relevant for the release.

@masterleinad masterleinad changed the title Add readability-implicit-bool-conversion [WIP] Add readability-implicit-bool-conversion May 20, 2021
@masterleinad masterleinad force-pushed the add_readability-implicit-bool-conversion branch 3 times, most recently from 3366245 to ca78945 Compare May 24, 2021 13:15
@bangerth
Copy link
Member

I took another look at this. I would be in favor of merging the code changes for purposes of readability, and we can consider the changes to the clang-tidy flags separately. Want to drop the latter part and update the former and get this merged?

@masterleinad
Copy link
Member Author

I took another look at this. I would be in favor of merging the code changes for purposes of readability, and we can consider the changes to the clang-tidy flags separately. Want to drop the latter part and update the former and get this merged?

Sure, I'll have a look.

@masterleinad masterleinad mentioned this pull request Dec 29, 2021
Merged
@masterleinad
Copy link
Member Author

See #13150.

@masterleinad masterleinad force-pushed the add_readability-implicit-bool-conversion branch 6 times, most recently from ed62418 to 75eb125 Compare January 4, 2022 15:01
@masterleinad masterleinad force-pushed the add_readability-implicit-bool-conversion branch from 75eb125 to abecc20 Compare January 11, 2022 17:37
@masterleinad masterleinad marked this pull request as ready for review January 11, 2022 17:37
@masterleinad masterleinad changed the title [WIP] Add readability-implicit-bool-conversion Add readability-implicit-bool-conversion Jan 11, 2022
bangerth
bangerth approved these changes Jan 11, 2022
View reviewed changes
include/deal.II/matrix_free/fe_evaluation.h
@@ -2980,7 +2980,7 @@ inline FEEvaluationBase<dim,
Assert(this->data == nullptr, ExcInternalError());
this->data =
new internal::MatrixFreeFunctions::ShapeInfo<VectorizedArrayType>(
Quadrature<dim - is_face>(quadrature),
Quadrature<(is_face ? dim - 1 : dim)>(quadrature),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this is so much more readable!

@bangerth bangerth merged commit b6ab9e4 into dealii:master Jan 11, 2022
@tjhei tjhei mentioned this pull request Jan 17, 2022
Merged
@bangerth bangerth mentioned this pull request Jan 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bangerth bangerth bangerth approved these changes

Assignees
No one assigned
Labels
ready to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@masterleinad @bangerth