Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.3.0] Remove Taskflow from 9.3 release branch #12286

Merged
merged 4 commits into from
May 22, 2021

Conversation

tamiko
Copy link
Member

@tamiko tamiko commented May 22, 2021

Closes #11740

@tamiko tamiko added this to the Release 9.3 milestone May 22, 2021
@tamiko tamiko changed the title Remove Taskflow from 9.3 release branch [9.3.0] Remove Taskflow from 9.3 release branch May 22, 2021
@drwells
Copy link
Member

drwells commented May 22, 2021

Should we run the test suite on this one?

@tamiko
Copy link
Member Author

tamiko commented May 22, 2021

/rebuild

@tamiko
Copy link
Member Author

tamiko commented May 22, 2021

Manually compiled and ran testsuite.

@tamiko tamiko merged commit f55c11c into dealii:dealii-9.3 May 22, 2021
@tjhei
Copy link
Member

tjhei commented May 22, 2021

Did you forget the tests?

@tamiko
Copy link
Member Author

tamiko commented May 22, 2021

@tjhei I did skip the tests for the time being. It's only quick_tests/taskflow.cc and multithreading/bench_01.cc and both have proper DEAL_II_WITH_TASKFLOW guards.

If you want we can clean up the tests for rc2

@tamiko tamiko deleted the disable-taskflow branch January 4, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants