Remove deprecated petsc things #12288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
approved these changes
May 23, 2021
marcfehling
reviewed
May 26, 2021
There was a problem hiding this comment.
The test lac/linear_operator_09 fails after this change. It still uses the old constructor:
dealii/tests/lac/linear_operator_09.cc
Lines 48 to 49 in c7680c2
I'm not familiar with the PETSc interface so I would be happy if you could take care of this.
| @@ -67,8 +70,18 @@ main(int argc, char **argv) | |||
| const unsigned int n_mpi_processes = static_cast<unsigned int>(n_jobs); | |||
| Assert(n_dofs % n_mpi_processes == 0, ExcInternalError()); | |||
| const unsigned int n_local_dofs = n_dofs / n_mpi_processes; | |||
There was a problem hiding this comment.
You don't use n_local_dofs anywhere in this test. Is that intentional?
There was a problem hiding this comment.
No - that should be removed.
|
Thanks for the heads up - I'll put up a followup PR to fix the other tests later. |
This was referenced May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were deprecated in #4341 - it's been four years, its time to say goodbye.