Rename VectorTools::evaluate_at_points() -> VectorTools::point_values() #12332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronbichler
approved these changes
May 28, 2021
|
I am in favor of putting this in for the 9.3 release branch, but we should aim for at least one more approval in that case, so let's wait for that. |
marcfehling
approved these changes
May 30, 2021
|
Since this function has been introduced in #11804 after the last release, I'm in favor in putting this in the 9.3 release branch as well. |
|
@marcfehling I have updated doc/news/9.2.0-vs-9.3.0.h directly. The other file does not exist anymore. |
|
I'll merge early as only the changelog has been modified and all testers were happy earlier. |
kronbichler
added a commit
that referenced
this pull request
May 30, 2021
[9.3] Take over #12332: Rename VectorTools::evaluate_at_points() -> VectorTools::point_values()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to be consistent with
VectorTools::point_value().If possible, I would like to make this change part of release 9.3, since this is a new function.
FYI @mschreter