Bugfix in MGTwoLevelTransfer::interpolate: forgot to copy vector #12344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
approved these changes
May 29, 2021
... and sorry for wasting your time ;) |
|
@kronbichler Would you mind to open a PR for the release branch. This is a bug which needs to be fixed before release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a serious bug in the
interpolatefunctions (and I spent more than hours on bisecting/backtracing an application code before looking here) that slipped into with #12012 as far as I can tell.The main problem was that we never test the result of the interpolation - well, we do write out some vtk files in a test but do not introspect them at all. Now I at least check the norm that would have sufficed to uncover the bug.