fix cmake underlinkage error #12478
Merged
fix cmake underlinkage error #12478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tamiko FYI maybe a candidate for 9.3.1... ? :-( |
tamiko
reviewed
Jun 19, 2021
The underlinkage MPI check under Ubuntu fails if MPI_CXX_LIBRARIES is empty, which happens if you configure with CXX=mpicxx (even though you should not). In this situation, just disable this hack. Errors look like this: CMake Error at cmake/modules/FindMPI.cmake:143 (LIST): LIST GET given empty list Call Stack (most recent call first): cmake/macros/macro_find_package.cmake:27 (_FIND_PACKAGE) cmake/configure/configure_1_mpi.cmake:28 (FIND_PACKAGE) /a/CMakeFiles/CMakeTmp/evaluate_expression.tmp:1 (FEATURE_MPI_FIND_EXTERNAL) cmake/macros/macro_evaluate_expression.cmake:30 (INCLUDE) cmake/macros/macro_configure_feature.cmake:237 (EVALUATE_EXPRESSION) cmake/configure/configure_1_mpi.cmake:81 (CONFIGURE_FEATURE) cmake/macros/macro_verbose_include.cmake:19 (INCLUDE) CMakeLists.txt:121 (VERBOSE_INCLUDE) CMake Error at cmake/modules/FindMPI.cmake:144 (GET_FILENAME_COMPONENT): GET_FILENAME_COMPONENT called with incorrect number of arguments Call Stack (most recent call first): cmake/macros/macro_find_package.cmake:27 (_FIND_PACKAGE) cmake/configure/configure_1_mpi.cmake:28 (FIND_PACKAGE) /a/CMakeFiles/CMakeTmp/evaluate_expression.tmp:1 (FEATURE_MPI_FIND_EXTERNAL) cmake/macros/macro_evaluate_expression.cmake:30 (INCLUDE) cmake/macros/macro_configure_feature.cmake:237 (EVALUATE_EXPRESSION) cmake/configure/configure_1_mpi.cmake:81 (CONFIGURE_FEATURE) cmake/macros/macro_verbose_include.cmake:19 (INCLUDE) CMakeLists.txt:121 (VERBOSE_INCLUDE) -- _mpi_libopen_pal_library not found! The call was: -- FIND_LIBRARY(_mpi_libopen_pal_library NAMES open-pal HINTS NO_DEFAULT_PATH NO_CMAKE_ENVIRONMENT_PATH NO_CMAKE_PATH NO_SYSTEM_ENVIRONMENT_PATH NO_CMAKE_SYSTEM_PATH NO_CMAKE_FIND_ROOT_PATH)
tjhei
force-pushed
the
mpi_underlinkage_bug
branch
from
37ec5c4
to
35fb3e2
Compare
tamiko
approved these changes
Jun 22, 2021
|
@tjhei Let's cherry-pick that onto the 9.3 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlinkage MPI check under Ubuntu fails if MPI_CXX_LIBRARIES is
empty, which happens if you configure with CXX=mpicxx (even though you
should not).
In this situation, just disable this hack. Errors look like this:
CMake Error at cmake/modules/FindMPI.cmake:143 (LIST):
LIST GET given empty list
Call Stack (most recent call first):
cmake/macros/macro_find_package.cmake:27 (_FIND_PACKAGE)
cmake/configure/configure_1_mpi.cmake:28 (FIND_PACKAGE)
/a/CMakeFiles/CMakeTmp/evaluate_expression.tmp:1
(FEATURE_MPI_FIND_EXTERNAL)
cmake/macros/macro_evaluate_expression.cmake:30 (INCLUDE)
cmake/macros/macro_configure_feature.cmake:237 (EVALUATE_EXPRESSION)
cmake/configure/configure_1_mpi.cmake:81 (CONFIGURE_FEATURE)
cmake/macros/macro_verbose_include.cmake:19 (INCLUDE)
CMakeLists.txt:121 (VERBOSE_INCLUDE)
CMake Error at cmake/modules/FindMPI.cmake:144 (GET_FILENAME_COMPONENT):
GET_FILENAME_COMPONENT called with incorrect number of arguments
Call Stack (most recent call first):
cmake/macros/macro_find_package.cmake:27 (_FIND_PACKAGE)
cmake/configure/configure_1_mpi.cmake:28 (FIND_PACKAGE)
/a/CMakeFiles/CMakeTmp/evaluate_expression.tmp:1
(FEATURE_MPI_FIND_EXTERNAL)
cmake/macros/macro_evaluate_expression.cmake:30 (INCLUDE)
cmake/macros/macro_configure_feature.cmake:237 (EVALUATE_EXPRESSION)
cmake/configure/configure_1_mpi.cmake:81 (CONFIGURE_FEATURE)
cmake/macros/macro_verbose_include.cmake:19 (INCLUDE)
CMakeLists.txt:121 (VERBOSE_INCLUDE)
-- _mpi_libopen_pal_library not found! The call was:
-- FIND_LIBRARY(_mpi_libopen_pal_library NAMES open-pal HINTS
NO_DEFAULT_PATH NO_CMAKE_ENVIRONMENT_PATH NO_CMAKE_PATH
NO_SYSTEM_ENVIRONMENT_PATH NO_CMAKE_SYSTEM_PATH NO_CMAKE_FIND_ROOT_PATH)