Fix bug in ParameterHandler::parse_input for .prm #12789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
entries_set_status
was not updated when parsing from .prm files.I am not super happy with my fix as it copies the lines from
ParameterHandler::set
into the .prm parsing logic. When parsing .xml and .json files, it seems to directly call theset
method. This inconsistency probably lead to the bug in the first place. Maybe it would be a good idea to callset
for the .prm case as well? I can do it in another PR if you agree.