VectorizedArray: accept std::initializer_list #12803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is nice, especially since missing entries are filled up with zeros for the case we switch architectures (to the extent the number of entries in the initializer list does not exceed the capacity). |
|
OK! Then I proceed here! |
peterrum
force-pushed
the
va_initializer_list
branch
from
ab13893
to
bf88029
Compare
peterrum
changed the title
|
Ready from my side :) |
kronbichler
approved these changes
Oct 10, 2021
doc/news/changes/minor/20211008Munch
Outdated
| @@ -0,0 +1,3 @@ | |||
| New: VectorizedArray can now constructed from an initializer list. | |||
There was a problem hiding this comment.
Suggested change
| New: VectorizedArray can now constructed from an initializer list. | |
| New: VectorizedArray can now be constructed from an initializer list. |
|
/rebuild |
peterrum
force-pushed
the
va_initializer_list
branch
from
bf88029
to
fd14853
Compare
|
The test failure is spurious. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something like this would be nice to be able to write:
Any opinions before add it to more VA specializations and a test?