Add assert to check the definition of CellData #12829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwells
approved these changes
Oct 14, 2021
|
/rebuild |
marcfehling
approved these changes
Oct 14, 2021
kronbichler
reviewed
Oct 15, 2021
include/deal.II/grid/connectivity.h
Outdated
Comment on lines
1503
to
1504
| "The definition of a cell has multiple times the same " | ||
| "vertex. This is not possible. A common reason is that " |
There was a problem hiding this comment.
I could not really understand this. Do you mean something like
Suggested change
| "The definition of a cell has multiple times the same " | |
| "vertex. This is not possible. A common reason is that " | |
| "The definition of a cell refers to the same vertex several " | |
| "times. This is not possible. A common reason is that " |
|
@kronbichler 's edit looks good. Thanks, @peterrum , for adding the exception! |
peterrum
force-pushed
the
celldata_assert
branch
from
8970a9b
to
0e83a8c
Compare
kronbichler
approved these changes
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assert would prevent issues as described in #12827 (comment).
FYI @bangerth