FE_Q_iso_Q1: varying subdivisions #12838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why can't we just use |
It assumes uniform subdivisions. |
peterrum
force-pushed
the
FE_Q_iso_Q1_varying_subdivisions
branch
2 times, most recently
from
bf55437
to
71ac540
Compare
kronbichler
reviewed
Oct 19, 2021
Comment on lines
246
to
248
| 1.0 - (x - points[index][0]) / | ||
| (points[index + 1][0] - | ||
| points[index][0])); |
There was a problem hiding this comment.
This division can potentially be expensive, as we might call value in inner loops. Do you think it would make sense to store a vector of one_over_lengths to ensure we only do multiplications?
There was a problem hiding this comment.
I have made the changes. Furthermore, I have added a test.
peterrum
force-pushed
the
FE_Q_iso_Q1_varying_subdivisions
branch
from
71ac540
to
dbc4da7
Compare
kronbichler
approved these changes
Oct 19, 2021
|
/rebuild |
Rombur
approved these changes
Oct 22, 2021
peterrum
force-pushed
the
FE_Q_iso_Q1_varying_subdivisions
branch
from
dbc4da7
to
d122a38
Compare
|
@Rombur Thanks for the review. I have fixed the typos! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim is:
None: I have introduced the classPiecewiseLinearPolynomial. But I guess it would be better to introduce the functionality inPiecewisePolynomialto prevent the need to perform dynamic_casts to the new class. Opinions?