DataOut for pyramids: reorder at the end #12847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
reviewed
Oct 19, 2021
source/base/data_out_base.cc
Outdated
| { | ||
| AssertDimension(patch.n_subdivisions, 1); | ||
|
|
||
| static std::array<unsigned int, 5> table = {{0, 1, 3, 2, 4}}; |
There was a problem hiding this comment.
Suggested change
| static std::array<unsigned int, 5> table = {{0, 1, 3, 2, 4}}; | |
| static const std::array<unsigned int, 5> table = {{0, 1, 3, 2, 4}}; |
peterrum
force-pushed
the
data_out_pyramids
branch
from
c083c45
to
a8ae801
Compare
peterrum
changed the title
kronbichler
approved these changes
Oct 21, 2021
|
/rebuild |
bangerth
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
references #12842
TODO: I still need to add a test, since the old DataOut implementation is not tested for pyramids.