MGTwoLevelTransfer: enable FE_Nothing #12891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronbichler
reviewed
Oct 27, 2021
Comment on lines
1640
to
1641
| for (unsigned int i = 0; i < fe_collection.size(); ++i) | ||
| result &= fu(fe_collection[i]); |
There was a problem hiding this comment.
Wouldn't it be easier or at least more readable with
Suggested change
| for (unsigned int i = 0; i < fe_collection.size(); ++i) | |
| result &= fu(fe_collection[i]); | |
| for (unsigned int i = 0; i < fe_collection.size(); ++i) | |
| if (!fu(fe_collection[i])) | |
| return false; |
and return true otherwise?
Comment on lines
1777
to
1779
| Assert(reference_cell == | ||
| dof_handler_coarse.get_fe(fe_index_pair.first.second) | ||
| dof_handler_coarse.get_fe(fe_index_pair.first.first) | ||
| .reference_cell(), | ||
| ExcNotImplemented()); |
There was a problem hiding this comment.
So this was a bug before, but we never actually triggered the alternative element?
There was a problem hiding this comment.
Yes. It was "just" an assert ;)
peterrum
force-pushed
the
gc_fe_nothing
branch
from
ddc346e
to
237310b
Compare
peterrum
changed the title
|
@kronbichler I have updated the PR. Ready from my side. |
|
/rebuild |
kronbichler
approved these changes
Oct 27, 2021
|
|
||
|
|
||
| /** | ||
| * TODO |
There was a problem hiding this comment.
Can you describe what the test is doing?
Comment on lines
+53
to
+70
| template <int dim> | ||
| class AnalyticalSolution : public Function<dim> | ||
| { | ||
| public: | ||
| AnalyticalSolution() | ||
| {} | ||
|
|
||
| virtual double | ||
| value(const Point<dim> &p, const unsigned int component = 0) const override | ||
| { | ||
| (void)component; | ||
|
|
||
| return p[0]; | ||
| } | ||
|
|
||
| private: | ||
| }; |
There was a problem hiding this comment.
How about using
dealii/include/deal.II/base/function_lib.h
Lines 1329 to 1330 in 21e7779
exponents = {1, 0, 0}?
peterrum
force-pushed
the
gc_fe_nothing
branch
from
237310b
to
392a312
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.