Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEValues: explicitly instantiate functions #12930

Closed
wants to merge 1 commit into from

Conversation

peterrum
Copy link
Member

@peterrum peterrum commented Nov 9, 2021

needed by #12756 (to be able to define FEValuesBase derived classes in other files)

FYI @simonsticko

@simonsticko
Copy link
Contributor

This is more directly related to #12024 than to #12756, since we agreed to move the new class in #12024 to NonMatching.

To be able to use this in #12024 we also need a new header fe/fe_values.templates.h and then move these classes to it:
FEValuesBase<dim, spacedim>::CellIteratorBase
FEValuesBase<dim, spacedim>::CellIterator
Right? Not sure if that should go in this pull-request or a separate one.

@peterrum
Copy link
Member Author

To be able to use this in #12024 we also need a new header fe/fe_values.templates.h and then move these classes to it:
FEValuesBase<dim, spacedim>::CellIteratorBase
FEValuesBase<dim, spacedim>::CellIterator
Right? Not sure if that should go in this pull-request or a separate one.

Exactly. I would do that in a follow-up PR. The PRs are easier to review this way.

Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not maintainable. We can't just import hundreds of lines of auto-generated code. That's particularly true given that the origin of these lines is from an expansion of the type

for (VEC : VECTOR_TYPES)

where VECTOR_TYPES depends on cmake configuration settings. You'll have to find a different way of doing what you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants