Optimize particle generation #12931
Merged
Optimize particle generation #12931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gassmoeller
force-pushed
the
optimize_particle_generation
branch
from
80441ca
to
cf37c2d
Compare
kronbichler
approved these changes
Nov 12, 2021
| @@ -270,6 +287,20 @@ namespace Particles | |||
| const Particle<dim, spacedim> &particle, | |||
| const typename Triangulation<dim, spacedim>::active_cell_iterator &cell); | |||
|
|
|||
| /** | |||
| * Insert a particle into the collection of particles given all the | |||
| * properties necessary for a particle. This function is used internally to | |||
There was a problem hiding this comment.
Could you slightly expand on what the user should think of the word internally here, given that the function is now public? It would also be good if particle_index is explained more clearly in terms of the expectations from outside.
|
/rebuild |
|
Thanks for the review. I updated the documentation. |
peterrum
approved these changes
Nov 13, 2021
This was referenced Mar 22, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some backwards compatible changes that make particle generation around 30-40% faster (in a test model in ASPECT).
Changes:
reservefunction. This avoids reallocation and movement of the vectors that store the data. We dont have an easy way to do the same for the vectors storing the handles into the property pool, but they are smaller, and at least we can pre-allocate 4 vectors (position,reference position, id, properties) of the 5 vectors (+handle into pool).ParticleHandler::insert_particlefunction that does not take a particle objectpublic. This avoids creating/copying/destroying a particle object if none is needed. Adjust the generators to use this function where possible.Generators::random_location_in_cellfunction. Previously the function would give up creating locations in the real cell after a number of unsuccessful tries and throw an exception. Now it falls back to creating locations in the unit cell, which always succeeds. If there are badly deformed cells it is more important to find any possible location at all rather than preserve perfectly randomly distributed particles within this cell.Possibly relevant for @kronbichler @peterrum @blaisb