Improve assert message in DictionaryPayLoad #12937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwells
requested changes
Nov 12, 2021
| "Multiple processes seem to own the same global index. " | ||
| "A possible reason is that the sets of locally owned " | ||
| "indices are not distinct.")); | ||
| Assert(interval.first < interval.second, ExcInternalError()); |
There was a problem hiding this comment.
We should move this assertion outside of the loop - it can never trigger in it since this is also the loop bounds.
There was a problem hiding this comment.
Oh, nevermind - there are no brackets around the first assert so this is outside the loop!
drwells
approved these changes
Nov 12, 2021
|
/rebuild |
|
Thanks! The tester seems to have run out of memory. Can you rebase and try again? |
|
/rebuild |
peterrum
force-pushed
the
mpi_compute_index_owner_internal_assert_message
branch
from
68012bb
to
5e5ae0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12933