Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve an error message. #12943

Merged
merged 1 commit into from
Nov 13, 2021
Merged

Improve an error message. #12943

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
36 changes: 30 additions & 6 deletions source/grid/tria.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2522,22 +2522,25 @@ namespace internal
if (dim >= 2)
process_subcelldata(connectivity.entity_to_entities(1, 0),
tria.faces->lines,
subcelldata.boundary_lines);
subcelldata.boundary_lines,
vertices);

// SubCellData: quad
if (dim == 3)
process_subcelldata(connectivity.entity_to_entities(2, 0),
tria.faces->quads,
subcelldata.boundary_quads);
subcelldata.boundary_quads,
vertices);
}


template <int structdim, typename T>
template <int structdim, int spacedim, typename T>
static void
process_subcelldata(
const CRS<T> & crs,
TriaObjects & obj,
const std::vector<CellData<structdim>> &boundary_objects_in)
const std::vector<CellData<structdim>> &boundary_objects_in,
const std::vector<Point<spacedim>> & vertex_locations)
{
AssertDimension(obj.structdim, structdim);

Expand Down Expand Up @@ -2605,8 +2608,29 @@ namespace internal
if (subcell_object->boundary_id !=
numbers::internal_face_boundary_id)
{
AssertThrow(boundary_id != numbers::internal_face_boundary_id,
ExcNotImplemented());
(void)vertex_locations;
AssertThrow(
boundary_id != numbers::internal_face_boundary_id,
ExcMessage(
"The input arguments for creating a triangulation "
"specified a boundary id for an internal face. This "
"is not allowed."
"\n\n"
"The object in question has vertex indices " +
[subcell_object]() {
std::string s;
for (const auto v : subcell_object->vertices)
s += std::to_string(v) + ',';
return s;
}() +
" which are located at positions " +
[vertex_locations, subcell_object]() {
std::ostringstream s;
for (const auto v : subcell_object->vertices)
s << '(' << vertex_locations[v] << ')';
return s.str();
}() +
"."));
boundary_id = subcell_object->boundary_id;
}
}
Expand Down