Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trilinos parallel is_non_negative() function #12968

Merged
merged 4 commits into from Jan 4, 2022
Merged

Trilinos parallel is_non_negative() function #12968

merged 4 commits into from Jan 4, 2022

Conversation

juleoc02
Copy link
Contributor

Changed the is_non_negative() function to work with distributed vectors in Trilinos. Mostly copied from the above all_zero() function that already worked in parallel

drwells
drwells previously requested changes Dec 1, 2021
View reviewed changes
Copy link
Member

@drwells drwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I have two small suggestions to make w.r.t. the MPI reduction.

source/lac/trilinos_vector.cc Outdated Show resolved Hide resolved
@bangerth
Copy link
Member

bangerth commented Dec 2, 2021

/rebuild

@jppelteret
Copy link
Member

@drwells, @bangerth Do you have any further comments, or is this now ready to be merged?

bangerth
bangerth reviewed Dec 28, 2021
View reviewed changes
Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but @juleoc02 is my student and when possible I try to avoid merging my students' PRs. So I would appreciate someone else do it!

masterleinad
masterleinad approved these changes Dec 28, 2021
View reviewed changes
Copy link
Member

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The implementation is pretty much the same as for all_zero.

@tamiko tamiko dismissed drwells’s stale review January 4, 2022 12:26

suggested changes have been implemented :-)

@tamiko tamiko merged commit 7d9f51a into dealii:master Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bangerth bangerth bangerth left review comments

@masterleinad masterleinad masterleinad approved these changes

@tamiko tamiko tamiko approved these changes

@drwells drwells Awaiting requested review from drwells

Assignees
No one assigned
Labels
ready to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@juleoc02 @bangerth @jppelteret @masterleinad @tamiko @drwells