Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix checkpointing with >2GB per process #12973

Merged
merged 1 commit into from Nov 24, 2021

Conversation

tjhei
Copy link
Member

@tjhei tjhei commented Nov 20, 2021

This fixes save/load of fixed and variable checkpointing where
individual ranks write more than 2GBs of data.
Part of #12873 and #12752
using facility added in #12964

This fixes save/load of fixed and variable checkpointing where
individual ranks write more than 2GBs of data.
Part of dealii#12873 and dealii#12752
Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose you have tested this with files this large?

@tjhei
Copy link
Member Author

tjhei commented Nov 24, 2021

I suppose you have tested this with files this large?

Yes by using the supplied test and changing the bool to big=true. I only checked MPICH though.

@tjhei tjhei deleted the checkpointing_large_part2 branch November 24, 2021 17:18
@bangerth
Copy link
Member

If I run this test with big==true and on two processes, it fails like so:

--------------------------------------------------------
An error occurred in line <1478> of file </raid/bangerth/p/deal.II/1/dealii/source/distributed/tria_base.cc> in function
    void dealii::parallel::DistributedTriangulationBase<dim, spacedim>::DataTransfer::save(unsigned int, unsigned int, const string&) const [with int dim = 3; int spacedim = 3; std::__cxx11::string = std::__cxx11::basic_string<char>]
The violated condition was: 
    ierr == MPI_SUCCESS
Additional information: 
    deal.II encountered an error while calling an MPI function.
    The description of the error provided by MPI is "MPI_ERR_ARG: invalid
    argument of some other kind".
    The numerical value of the original error code is 13.
--------------------------------------------------------

This is with the older OpenMPI version. (The comment you added makes me scared to run this on my laptop.) Is this to be expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants