Move FEEvaluationImplHangingNodes::run_internal() into a specialized class #12997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
commented
Nov 26, 2021
| @@ -50,355 +52,384 @@ namespace internal | |||
| & c_mask, | |||
| Number *values) | |||
| { | |||
| Runner<RunTypes::vectorized, fe_degree> runner; | |||
There was a problem hiding this comment.
The idea is to have:
Runner<(fe_degree > 3 || fe_degree == -1 ) ? RunTypes::vectorized : RunTypes::scalar,
fe_degree> runner;
peterrum
force-pushed
the
FEEvaluationImplHangingNodes_runner
branch
from
5f9e334
to
6958093
Compare
kronbichler
approved these changes
Nov 26, 2021
peterrum
force-pushed
the
FEEvaluationImplHangingNodes_runner
branch
from
6958093
to
3b349ab
Compare
kronbichler
approved these changes
Nov 26, 2021
peterrum
force-pushed
the
FEEvaluationImplHangingNodes_runner
branch
2 times, most recently
from
b0f29e0
to
b456c8e
Compare
peterrum
force-pushed
the
FEEvaluationImplHangingNodes_runner
branch
from
3b65cb6
to
a50ed3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #12996