Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pre-compiled code for CellwiseInverseMassMatrix #13003

Merged
merged 1 commit into from Nov 29, 2021

Conversation

kronbichler
Copy link
Member

By looking at a profiler output I realized that CellwiseInverseMassMatrix would not use the optimized pre-compiled version of the code with compile-time loop bounds, but rather the slower path with run-time loop bounds. It turned out that we forgot to add the respective call to the templated/precompiled code in CellwiseInverseMassMatrix. While there, I also simplified the calls slightly as the fe degree can be read in a more central place.

@peterrum
Copy link
Member

The following tests FAILED:
	2545 - matrix_free/inverse_mass_02.debug (Failed)
	2580 - matrix_free/advect_1d.debug (Failed)
	2581 - matrix_free/inverse_mass_01.debug (Failed)
	2584 - matrix_free/advect_1d_vectorization_mask.debug (Failed)
	2640 - matrix_free/inverse_mass_03.debug (Failed)
	2689 - matrix_free/advect_1d_system.debug (Failed)
	2691 - matrix_free/inverse_mass_05.debug (Failed)

@kronbichler
Copy link
Member Author

Thanks, I had only executed the relevant application but not the other code path. Good to have some tests. 😄

@peterrum peterrum merged commit 24fafe1 into dealii:master Nov 29, 2021
@kronbichler kronbichler deleted the mf_cellwise_mass_use_template branch November 29, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants