Avoid dereferencing a past-the-end iterator #13004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
approved these changes
Nov 29, 2021
bangerth
reviewed
Nov 29, 2021
include/deal.II/base/utilities.h
Outdated
| @@ -1307,7 +1307,8 @@ namespace Utilities | |||
| #else | |||
| (void)allow_compression; | |||
| #endif | |||
| fisb.push(boost::iostreams::array_source(&*cbegin, &*cend)); | |||
| fisb.push( | |||
| boost::iostreams::array_source(&*cbegin, &*cbegin + (cend - cbegin))); | |||
There was a problem hiding this comment.
Example 34.3 of https://theboostcpplibraries.com/boost.iostreams-devices suggests that we could write this as
Suggested change
| boost::iostreams::array_source(&*cbegin, &*cbegin + (cend - cbegin))); | |
| boost::iostreams::array_source(&*cbegin, cend - cbegin)); |
Indeed, this overload exists: https://www.boost.org/doc/libs/1_76_0/libs/iostreams/doc/classes/array.html
There was a problem hiding this comment.
Thanks @bangerth , I applied it.
kronbichler
force-pushed
the
avoid_invalid_memory_access
branch
from
fb21c69
to
6e4c3c4
Compare
bangerth
approved these changes
Nov 29, 2021
masterleinad
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.