Fix a memory leak in AlignedVector. #13005
Conversation
| resize(0); | ||
| resize_fast(vec.used_elements_end - vec.elements.get()); | ||
| reserve(new_size); |
There was a problem hiding this comment.
The bug is here: When we call resize_fast(), we allocate memory and default construct objects in that memory. But in the line below (AlignedVectorCopyConstruct) we copy-construct other objects in that same memory location, forgetting to call the destructor on what we had done before.
The solution is to not initialize the memory we allocate -- that's what reserve() does in contrast to resize*().
There was a problem hiding this comment.
For reference, on second look, I see that in essence the same code I just wrote here is also what's in the copy constructor just a few lines up.
|
@elauksap FYI. |
That's brilliant, thanks a lot! |
|
@elauksap Could you try out this patch without #12995. |
|
I would vote for keeping the patch, it is a nice use of compile-time knowledge and hence more direct in my opinion. |
Fixes #12998. As pointed out in #12993.
/rebuild