Functions for calculating angles between vectors. #13008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
reviewed
Nov 30, 2021
include/deal.II/physics/relations.h
Outdated
| Physics::Relations::angle(const Tensor<1, spacedim, Number> &a, | ||
| const Tensor<1, spacedim, Number> &b) | ||
| { | ||
| Assert(a.norm() > 1.e-12 && b.norm() > 1.e-12, |
There was a problem hiding this comment.
I'm not generally a fan of these sorts of comparisons because the vectors may well have physical units -- and in that case, what is small and what is large is all relative. I wouldn't object to a comparison of the form
Suggested change
| Assert(a.norm() > 1.e-12 && b.norm() > 1.e-12, | |
| Assert(a.norm() > 1.e-12*b.norm() && b.norm() > 1.e-12*a.norm(), |
kronbichler
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Looks good to me, apart from the comment already given by @bangerth
|
/rebuild I've addressed all comments. Could you have another look? |
bangerth
approved these changes
Nov 30, 2021
kronbichler
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For future patches, I need to calculate angles between vectors, but found similar functionality already hidden in the library. I thought it would be a good idea to make them available throughout the library.
I thought the
Physicsnamespace would be good place for these functions. Since they are short I left the implementation in the header and flagged theminline. I would like to know what you think of this approach. We can move these functions to more appropriate places if you have better ideas :-)