Boost includes: use BOOST_ALLOW_DEPRECATED_HEADERS to suppress warnings #13021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamiko
commented
Dec 1, 2021
| #define BOOST_CONFIG_HEADER_DEPRECATED_HPP_INCLUDED | ||
| #define BOOST_HEADER_DEPRECATED(a) _Pragma(\"GCC error \\\"stop compilation\\\"\"); | ||
| #include <boost/geometry/index/rtree.hpp> | ||
| int main() { return 0; } |
There was a problem hiding this comment.
@bangerth This isn't particularly pretty but it works: I had to override the BOOST_HEADER_DEPRECATED(a) macro in order to force a compilation error. -Werror doesn't help here because a #pragma message is not a warning...
There was a problem hiding this comment.
Ah, clever. That's why my test didn't fail.
bangerth
approved these changes
Dec 1, 2021
| #define BOOST_CONFIG_HEADER_DEPRECATED_HPP_INCLUDED | ||
| #define BOOST_HEADER_DEPRECATED(a) _Pragma(\"GCC error \\\"stop compilation\\\"\"); | ||
| #include <boost/geometry/index/rtree.hpp> | ||
| int main() { return 0; } |
There was a problem hiding this comment.
Ah, clever. That's why my test didn't fail.
tamiko
force-pushed
the
avoid_spurious_boost_warnings
branch
from
3edd4f6
to
1c2f6c4
Compare
|
/rebuild |
kronbichler
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #13020