Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow accessing face numbers in data postprocessors #13027

Merged
merged 5 commits into from Dec 6, 2021

Conversation

bangerth
Copy link
Member

@bangerth bangerth commented Dec 3, 2021

Classes derived from DataPostprocessor already have access to the cell being worked on right now, but when the work is done by DataOutFaces, they cannot access the face number. This patch fixes that, adds a test, and shows an example in the documentation.

/rebuild

Copy link
Member

@drwells drwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature.

Could you also change set_cell() to reset the face number to numbers::invalid_unsigned_int? The extra check would be nice.

Comment on lines 80 to 81
// -------------------------- DataPostprocessorScalar
// -------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix this whitespace change?

@bangerth
Copy link
Member Author

bangerth commented Dec 5, 2021

Done as requested!

@drwells drwells merged commit 13a4730 into dealii:master Dec 6, 2021
@bangerth bangerth deleted the face_number branch December 6, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants