Enable GridOut::write_gmsh() for simplex meshes #13035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwells
requested changes
Dec 6, 2021
|
Its not directly related to this PR (the same problems occurs with VTK) but I see the following when I plot the output:
I think this means that point placement currently ignores manifold descriptions. |
|
I fixed the one place the tester complains about. As for the figure: This looks correct to me. Remember that I'm outputting the mesh with linear tetrahedra. So only the vertex positions are right, but lines are shown as straight whether they are or are not based on some (deal.II-internal) manifold description. The vertex positions look correct to me: all on the perimeter of the cylinder. |
|
Yes, I think you're right. I'll double-check the grid later. |
drwells
approved these changes
Dec 6, 2021
kronbichler
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to put some of the necessary infrastructure into
ReferenceCell./rebuild