p::f::T: allow repartitioning #13038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
force-pushed
the
pft_repartition
branch
from
dc00190
to
101e949
Compare
peterrum
changed the title
kronbichler
reviewed
Dec 13, 2021
| { | ||
| Assert(cell->at_boundary(pair.first), | ||
| ExcMessage("Cell face is not on the boundary!")); | ||
| if (cell->face(pair.first)->at_boundary()) |
There was a problem hiding this comment.
Is this safe? Or do we have a way to check the previous check when we know the data is comprehensive?
There was a problem hiding this comment.
This is safe. We are re-partitioning p:f:T. Here we still don't have a good mean to distinguish between actual boundary cells and calls at the boundary of the locally-relevant coarse grid. Such internal boundaries, cause the problem here - but can be safely ignored.
kronbichler
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to reparation p::f::T with the help of
RepartitioningPolicyTools.To allow AMR for p::f::T, one needs to revive #8834. Also a
RepartitioningPolicyToolsclass that wrapsParmetiswould be nice! Anyone interested in doing that?FYI @elauksap @drwells