MatrixFree: distinguish internally between mixed and non-mixed meshes #13042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
commented
Dec 7, 2021
Comment on lines
742
to
745
| const auto &reference_cells = triangulation.get_reference_cells(); | ||
| const bool is_mixed_mesh = reference_cells.size() > 1 || | ||
| ((reference_cells[0].is_hyper_cube() || | ||
| reference_cells[0].is_simplex()) == false); |
There was a problem hiding this comment.
Does it make sense to move this into Triangulation?
There was a problem hiding this comment.
I think this is simple enough to keep it here, as long as it is not used more widely. But it's good to keep an eye on it.
There was a problem hiding this comment.
I believe that such a function could be useful in the future for other purposes, so I think it would be well suited for Triangulation. Also, we might forget that this functionality already exists here, and duplicate code in the future.
I am pro Triangulation::is_mixed_mesh().
There was a problem hiding this comment.
There was a problem hiding this comment.
|
/rebuild |
kronbichler
approved these changes
Dec 9, 2021
peterrum
force-pushed
the
mf_mixed_internal
branch
from
be3e31b
to
1488718
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.