Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TBB to github actions. #13057

Merged
merged 1 commit into from Dec 14, 2021
Merged

Conversation

marcfehling
Copy link
Member

We might not have fully ported oneTBB yet f743db9, but we can identify it now and fallback to the bundled version since #12958.

Nevertheless, we can already add oneTBB to github-actions to

  • double-check that our fallback solution works
  • help verifying our implementation while continuing to port oneTBB

I hope this works. If not, we can leave this WIP.

@marcfehling
Copy link
Member Author

marcfehling commented Dec 9, 2021

Seems to work: https://github.com/dealii/dealii/runs/4475392720
@tamiko -- FYI

-- Include /home/runner/work/dealii/dealii/cmake/configure/configure_1_tbb.cmake
-- TBB_LIBRARY not found! The call was:
--     FIND_LIBRARY(TBB_LIBRARY NAMES tbb HINTS /opt/intel/oneapi/tbb/2021.4.0 PATH_SUFFIXES lib lib64 lib)
-- TBB_DEBUG_LIBRARY not found! The call was:
--     FIND_LIBRARY(TBB_DEBUG_LIBRARY NAMES tbb_debug HINTS /opt/intel/oneapi/tbb/2021.4.0 PATH_SUFFIXES lib lib64 lib)
-- TBB_INCLUDE_DIR not found! The call was:
--     FIND_PATH(TBB_INCLUDE_DIR tbb/tbb_stddef.h HINTS /opt/intel/oneapi/tbb/2021.4.0 PATH_SUFFIXES include include/tbb tbb)
-- Found TBB_INCLUDE_DIR
--   TBB_VERSION: 2021.4
--   TBB_LIBRARIES: *** Required variable "TBB_LIBRARY" set to NOTFOUND ***
--   TBB_INCLUDE_DIRS: /opt/intel/oneapi/tbb/2021.4.0/include
--   TBB_USER_INCLUDE_DIRS: /opt/intel/oneapi/tbb/2021.4.0/include
-- Could NOT find TBB
-- deal.II is not fully ported to the new TBB oneAPI interface, disabling external TBB
-- DEAL_II_WITH_TBB has unmet external dependencies.
-- Performing Test DEAL_II_HAVE_FLAG_Wno_parentheses
-- Performing Test DEAL_II_HAVE_FLAG_Wno_parentheses - Success
-- DEAL_II_WITH_TBB successfully set up with bundled packages.

-D MPI_DIR=${I_MPI_ROOT} \
-D BLAS_DIR=${MKLROOT} \
-D LAPACK_DIR=${MKLROOT} \
-D TBB_DIR=${TBBROOT} \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that something that's set in the OS?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command source /opt/intel/oneapi/setvars.sh sets all relevant environment variables, i.e., I_MPI_ROOT, MKLROOT, and TBBROOT.

See also https://www.intel.com/content/www/us/en/develop/documentation/get-started-with-intel-oneapi-dlfd-linux/top/before-you-begin.html

@bangerth
Copy link
Member

/rebuild

@marcfehling
Copy link
Member Author

/rebuild

As this PR only affects the github-actions workers, we could technically skip the jenkins tests.

@bangerth
Copy link
Member

I'm no expert on the CI infrastructure. Would someone who knows this area make a call here?

Copy link
Member

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@masterleinad masterleinad merged commit 369096b into dealii:master Dec 14, 2021
@marcfehling marcfehling deleted the support_tbb branch December 14, 2021 18:36
marcfehling added a commit to marcfehling/dealii that referenced this pull request Jan 13, 2022
marcfehling added a commit to marcfehling/dealii that referenced this pull request Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants