MatrixFree::gather_evalute(): allow mixed numbers #13076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronbichler
reviewed
Dec 15, 2021
Comment on lines
85
to
89
| const Number * src_ptr, | ||
| const std::vector<ArrayView<const Number>> * sm_ptr, | ||
| const Number2 * src_ptr, | ||
| const std::vector<ArrayView<const Number2>> * sm_ptr, |
There was a problem hiding this comment.
Shouldn't we be able to avoid Number2 here and just use Number, hence implying Number != VectorizedArrayType::value_type? I see no reason to need the underlying scalar type of VectorizedArrayType, unless I am missing something.
kronbichler
approved these changes
Dec 15, 2021
|
/rebuild |
peterrum
force-pushed
the
gather_evaluate_mixed
branch
from
b69b462
to
0178acc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.