Fixed bug in SparseDirectUMFPACK #12916

[kuljitvirk]

Updated author name as requested to be a full name.

[bangerth]

Let's see what the tester says here :-)

/rebuild

[bangerth]

Assuming that this passes the test suite, would you mind also adding an entry in the doc/news/changes/minor directory that follows the same scheme as the files already there?

[bangerth]

/rebuild

[bangerth]

Would you still be willing to add an entry to the changelog?

[jppelteret]

Looks good @kuljitvirk, but perhaps you could add a changelog entry as @bangerth requested.

[masterleinad]

Looks good @kuljitvirk, but perhaps you could add a changelog entry as @bangerth requested.

I think we should just merge the pull request since it fixes a bug. A changelog entry can be added later.

[kuljitvirk]

I will add a changelog entry tomorrow. I was away. Just got back.

…

On Mon, Dec 27, 2021 at 12:23 PM Jean-Paul Pelteret < ***@***.***> wrote: ***@***.**** approved this pull request. Looks good @kuljitvirk <https://github.com/kuljitvirk>, but perhaps you could add a changelog entry as @bangerth <https://github.com/bangerth> requested. — Reply to this email directly, view it on GitHub <#13095 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACXVS6K4MMBFOKSHDMZTGUDUTDDNVANCNFSM5KH3OKCA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[bangerth]

Ping? I have a follow-up but would like to wait till this is merged.

[jppelteret]

I think we should just merge the pull request since it fixes a bug. A changelog entry can be added later.

Let's just do as @masterleinad suggests.

[bangerth]

I've added the missing changelog entry in #13175.