Add a bit of documentation to MPI::compute_point_to_point_communication_pattern() #13147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
source/base/mpi.cc
Outdated
Comment on lines
414
to
417
| else | ||
| // If that was not the case, we need to use the remainder of the code | ||
| // below, i.e., just fall through the else branch here | ||
| {} |
There was a problem hiding this comment.
I would prefer to just omit this.
Suggested change
| else | |
| // If that was not the case, we need to use the remainder of the code | |
| // below, i.e., just fall through the else branch here | |
| {} |
There was a problem hiding this comment.
Suggested changes spanning multiple lines, finally! 😃
|
Updated. |
|
Ping? |
masterleinad
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #13097.
I took the liberty to simplify the condition at the beginning a little bit by way of a lambda function. The rest of the patch might be hard to read because I removed a gratuitous pair of
{...}, so look at it with whitespace off./rebuild