Fix compilation with boost 1.78. #13165
Conversation
I bisected (fortunately Boost.Geometry a header-only library so adding the include directory sufficed) and boostorg/geometry@6eb9e23 is where this problem starts for us. See also boostorg/geometry#792 - the easiest fix for all such issues is to just include the project header `boost/geometry/geometry.hpp`. In this particular case, if you look at the commit which causes grid_tools.cc fails to compile, its because we were relying on some implicit includes. In particular, we need the distance header to find the distance between points and boxes, but that was previously included in another file.
drwells
force-pushed
the
fix-boost-1.78
branch
from
8ba7fae
to
e0e7683
Compare
|
@drwells This is amazingly small fix! Would you mind reverting the CMake check for 1.77? I am verifying that deal.II builds against 1.77 as we speak. |
|
I can add it to this PR, but you mentioned here that there is another problem with Boost.Math - this fix may not be sufficient to get things working with 1.77. |
…eam bugs" This reverts commit badbdc8.
|
My hybrid Boost 1.78 and Boost.Geometry 1.77 setup avoids the distance problem so we can probably skip reverting 4e0698c. |
|
@drwells Roger, let's leave for now but for the record: I was able to compile dealii 9.3.1 with this PR against boost 1.77. At least against boost 1.77 with a couple of patches... |
|
To be clear, do you mean that we should remove b15edaa from this PR? |
|
@drwells I missed the fact that you added it. Let's keep the revert. |
|
Do you want to propose this for backporting to the 9.3 branch? |
Add a changelog entry for #13165.
Fixes #13037 - I can now compile the library with 1.78 on my desktop.
I bisected (fortunately Boost.Geometry a header-only library so adding the include directory sufficed) and
boostorg/geometry@6eb9e23 is where this problem starts for us. See also boostorg/geometry#792 - the easiest fix for all such issues is to just include the project header
boost/geometry/geometry.hpp.In this particular case, if you look at the commit which causes
grid_tools.ccfails to compile, its because we were relying on some implicit includes. In particular, we need the distance header to find the distance between points and boxes.