Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more tests for iterator filters #13170

Merged
merged 4 commits into from Jan 6, 2022

Conversation

jppelteret
Copy link
Member

@jppelteret jppelteret commented Jan 5, 2022

Fixes #13169

@jppelteret
Copy link
Member Author

@simonsticko Can you check if this works for you?

@jppelteret
Copy link
Member Author

/rebuild

@bangerth
Copy link
Member

bangerth commented Jan 5, 2022

You currently have this error in a number of places:

/jenkins/workspace/dealii_PR-13170/tests/grid/filtered_iterator_07_operator.cc:55:26: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
   Assert(n_cells_visited == Utilities::fixed_power<dim>(2),
                          ^

(Also line 99, and in the corresponding test without _operator in the name.)

@simonsticko
Copy link
Contributor

@simonsticko Can you check if this works for you?

Yes, works for me. 👍

@jppelteret
Copy link
Member Author

Yes, works for me.

Great, thanks for the confirmation.

You currently have this error in a number of places:

Thanks for the heads up. I've changed the counter type from unsigned int to int.

@bangerth bangerth merged commit d6c45b5 into dealii:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compilation Error when Combining IteratorFilter with FEInterfaceValues
3 participants