Fix a check for zero entries in the lumped mass matrix. #13211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild |
peterrum
approved these changes
Jan 10, 2022
tamiko
approved these changes
Jan 10, 2022
masterleinad
approved these changes
Jan 10, 2022
kronbichler
approved these changes
Jan 10, 2022
bangerth
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unrelated to #13179 but I noticed it while examining one of the failing tests (threading with oneAPI causes vectors to apparently be set to all zeros, which creates a floating point exception).
It doesn't make sense to check the values of
inverse_lumped_diagonalhere - that's what we are computing. The check should be on the values of the lumped mass matrix.