Make reference to SUNDIALS solvers in step-26. #13241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
reviewed
Jan 15, 2022
examples/step-26/doc/results.dox
Outdated
| methods by hand as we do here. Rather, one should use one of the available | ||
| high-quality libraries for time stepping, for the same reasons as one should | ||
| not be implementing finite element methods by hand but use deal.II instead. | ||
| Indeed, deal.II has interfaces to one such library, |
There was a problem hiding this comment.
I read this sentence like: Indeed, deal.II has interfaces to one such finite-element library, ...
examples/step-26/doc/results.dox
Outdated
Comment on lines
95
to
96
| As a general rule, however, one should not be implementing time stepping | ||
| methods by hand as we do here. Rather, one should use one of the available |
There was a problem hiding this comment.
I wouldn't write shouldn't. There are good reasons to use specialized time-stepping methods for FEM: 1) performance and 2) certain types of problems need specialized time-stepping approaches (dual splitting for incompressible NS), which are often not part of such general libraries. Indeed, for simple cases general-purpose libraries are a very good option.
|
Good points, thank you! |
peterrum
approved these changes
Jan 15, 2022
kronbichler
approved these changes
Jan 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've spent the week at a workshop on time discretizations. I should live what I preach -- that one should use external libraries instead of hand-coding things -- but we did not have SUNDIALS interfaces at the time when step-26 was written. The second best thing is to at least say so.
/rebuild