Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary include file #13244

Merged
merged 1 commit into from Jan 15, 2022
Merged

Remove unnecessary include file #13244

merged 1 commit into from Jan 15, 2022

Conversation

kronbichler
Copy link
Member

As far as I can see, there is not reference to VectorTools in this file.

@peterrum
Copy link
Member

/jenkins/workspace/dealii-tidy_PR-13244/include/deal.II/matrix_free/fe_point_evaluation.h:882:11: error: implicit conversion 'dealii::UpdateFlags' -> bool [readability-implicit-bool-conversion,-warnings-as-errors]
/jenkins/workspace/dealii-tidy_PR-13244/include/deal.II/matrix_free/fe_point_evaluation.h:886:11: error: implicit conversion 'dealii::UpdateFlags' -> bool [readability-implicit-bool-conversion,-warnings-as-errors]
/jenkins/workspace/dealii-tidy_PR-13244/include/deal.II/matrix_free/fe_point_evaluation.h:893:11: error: implicit conversion 'dealii::UpdateFlags' -> bool [readability-implicit-bool-conversion,-warnings-as-errors]

Introduced by #12983. We should disable the check until we have a decision!

@kronbichler
Copy link
Member Author

Let us merge this one as it does not affect any of the tidy checks.

@kronbichler kronbichler merged commit d78515f into dealii:master Jan 15, 2022
@kronbichler kronbichler deleted the remove_unnecessary_include branch May 11, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterrum peterrum peterrum approved these changes

Assignees
No one assigned
Labels
DoFs ready to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kronbichler @peterrum