Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.3] Fix flags bug point_values #13284

Merged
merged 1 commit into from Jan 24, 2022

Conversation

bergbauer
Copy link
Contributor

no known conversion for argument 3 from ‘const dealii::VectorTools::EvaluationFlags::EvaluationFlags’ to ‘dealii::UpdateFlags’

Found through a compilation error in our user code. Use update_values like on current master branch (refactored code) to fix it.

@peterrum

Copy link
Member

@peterrum peterrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is your intention indeed to merge into the deal.II 9.3 release branch? On master this function has been completely rewritten to support also gradients.

Apart from that, it looks correct for this case 👍

@marcfehling marcfehling changed the title Fix flags bug point_values [9.3] Fix flags bug point_values Jan 24, 2022
@bergbauer
Copy link
Contributor Author

Yes this is intentional! We should test the build against release 9.3 in exadg.

@drwells
Copy link
Member

drwells commented Jan 24, 2022

/rebuild

@drwells drwells mentioned this pull request Jan 24, 2022
@tamiko tamiko merged commit 8c47427 into dealii:dealii-9.3 Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants