New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: call CMake's FindHDF5 instead of trying to find everything by hand #13319
Conversation
9bed2c7
to
d47c22e
Compare
d47c22e
to
7023fac
Compare
/rebuild |
@tjhei With this change HDF5 is now configured and enabled on the CI:
... and two HDF5 tests fail for the serial configuration. I checked, we have not tested a serial configuration with non-mpi hdf5 in about forever. Also, almost all of our hdf5 tests require MPI to be enabled. So what do? |
Not sure if anyone uses hdf5 without MPI? I would suggest to require MPI. This makes testing easier for us. |
I think that, for the sake of our sanity, we should require MPI with HDF5 for the same reasons we require Trilinos with HDF5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
The possibilities for extensions of step-3 have a long section on using HDF5 and explicitly state that "Although the HDF5 deal.II binding supports both serial and MPI...". I'm not sure that we ever use HDF5 without MPI, but you might want to read through https://dealii.org/developer/doxygen/deal.II/step_3.html#UsingHDF5tooutputthesolutionandadditionaldata to see what we ought to do. |
I would be in favor of merging as is and then tackling this separately by somebody who is interested in sequential hdf5:
|
Closes #8957