Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new CA interface instead of using AnonymousProcess. #13326

Merged
merged 1 commit into from Feb 10, 2022

Conversation

bangerth
Copy link
Member

@bangerth bangerth commented Feb 2, 2022

This switches our uses of the CA algorithms from the old AnonymousProcess approach to using the interfaces introduced by #13208/#13272.

The patch might be easiest to read when ignoring whitespace changes. Basically, it does two things:

  • Where previously we built an AnonymousProcess object that takes 3 unnamed lambda functions as arguments, I now generally just create 3 named lambda functions and pass these as arguments to the CA run() functions. Some of these functions are non-trivial and I thought it useful to give them names.
  • In the old interface, these functions return their information through the last function argument. The new interface requires that they just return objects.

There should be no functional changes in this patch.

/rebuild

@bangerth
Copy link
Member Author

bangerth commented Feb 2, 2022

Yes, reading the patch via https://github.com/dealii/dealii/pull/13326/files?w=1 is easier.

@bangerth
Copy link
Member Author

What should we do here?

@drwells drwells merged commit 7e5b33a into dealii:master Feb 10, 2022
@bangerth bangerth deleted the ca-interface-2 branch February 11, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants