Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove forward declarations of MappingQ #13330

Merged
merged 2 commits into from Feb 3, 2022
Merged

remove forward declarations of MappingQ #13330

merged 2 commits into from Feb 3, 2022

Conversation

nfehn
Copy link
Contributor

@nfehn nfehn commented Feb 3, 2022

closes #13329

@nfehn nfehn mentioned this pull request Feb 3, 2022
Closed
kronbichler
kronbichler approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@kronbichler kronbichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for testing.

@kronbichler
Copy link
Member

/rebuild

marcfehling
marcfehling approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@marcfehling marcfehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! If it doesn't work, it helps to simply hide the forward declaration from doxygen like here #13276.

@nfehn
Copy link
Contributor Author

nfehn commented Feb 3, 2022

@marcfehling I chose your suggestion for MappingQCache, where removing the forward declaration is not so easy.

@kronbichler kronbichler merged commit b456483 into dealii:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterleinad masterleinad masterleinad approved these changes

@kronbichler kronbichler kronbichler approved these changes

@marcfehling marcfehling marcfehling approved these changes

Assignees
No one assigned
Labels
Mapping ready to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link to wrong header file in Docu of MappingQ?
4 participants
@nfehn @kronbichler @masterleinad @marcfehling