VTU: put closing XML on separate line #13336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We try to output VTU XML data in somewhat pretty way like
<Points>
<DataArray type="Float32" NumberOfComponents="3" format="binary">
[BASE64 data]
</DataArray>
</Points>
but we were missing a newline after writing scalar base64 data. Fix
this.
kronbichler
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe not a very important change 馃槃 , but I noticed that we are inconsistent about newlines of closing XML tags.
Tests are updated with search&replace and pass on my machine (but this is a single configuration with zlib and mpi, etc.).