Add MGSmootherPrecondition::initialize_matrices() #13343
Conversation
There was a problem hiding this comment.
OK with me, but I must say that I am surprised that we expose the smoothers as public member variables in this class, which makes this way of initialization possible at all. But I guess it is as you say, one might want to have additional flexibility in the solver.
| @@ -467,6 +467,15 @@ class MGSmootherPrecondition : public MGSmoother<VectorType> | |||
| const typename PreconditionerType::AdditionalData & | |||
| additional_data = typename PreconditionerType::AdditionalData()); | |||
|
|
|||
| /** | |||
| * In contrast to the function above, only initialize the matrices. The | |||
| * smoothers need to be setup manually by the user in the following. This | |||
There was a problem hiding this comment.
| * smoothers need to be setup manually by the user in the following. This | |
| * smoothers need to be set up manually by the user as a subsequent step in the code. This |
| /** | ||
| * In contrast to the function above, only initialize the matrices. The | ||
| * smoothers need to be setup manually by the user in the following. This | ||
| * is useful if one wants full flexibility in the choice of smoothers. |
There was a problem hiding this comment.
Maybe you can explain a bit more how this works: By manually setting the public member variable smoothers?
peterrum
force-pushed
the
initialize_matrices
branch
from
9359a70
to
f016c10
Compare
I was also surprised by this. I think a setter function allowing controlled access to the level smoothers would have been a better choice. @kronbichler I have addressed your comments! |
|
/rebuild |
I would like to setup
MGSmootherPreconditionlevel by level, not using theinitialize()functions, which also initialize the preconditioners. The best would be to have a functioninitialize(const MGLevelObject<MatrixType2> &matrices)but that conflicts with the function with the same name that takes optionally anAdditonalDataobject.