New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add performance testing framework: preparatory refactoring #13350
Conversation
26f3675
to
7940075
Compare
/rebuild |
8405424
to
3d745b1
Compare
200dd2b
to
5b63ed2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for making the first steps!
Since I am too much involved here, I would appreciate a second opinion!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge. More is coming!
@peterrum and I are currently working on bringing back performance tests to deal.II. Our idea is to integrate performance tests as a part of the testsuite with the following rationale:
RUN
orDIFF
). This will ensure that compilation and linking of performance test code is part of our CI and does not diverge from the library API.ctest
(and our testsuite infrastructure) to compile and run performance tests that simply report (a best of three) timing result to the output file. These output files can then further be postprocessed by a script to create a table. All of this will be chained together in arun_performance_tests.cmake
ctest script.This PR adds some necessary features to the current testsuite infrastructure:
[...].threads=XY.output
TEST_THREAD_LIMIT
andTEST_MPI_RANK_LIMIT
. Tests that specify a higher number of MPI ranks or thread concurrency will be dropped..threads=max.
or.mpirun=max.
.