Implement new Table<3, T>::reinit() #13364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamiko
reviewed
Feb 12, 2022
| @@ -1549,6 +1549,18 @@ class Table<3, T> : public TableBase<3, T> | |||
| InputIterator entries, | |||
| const bool C_style_indexing = true); | |||
There was a problem hiding this comment.
Wouldn't it be possible to simply implement any size with a variadic template?
There was a problem hiding this comment.
You could, like the TableIndices class does (see #13375, completely coincidentally). The problem is that variadic template packs must come last in the argument list, and so these kinds of functions can also not have trailing defaulted arguments.
tamiko
approved these changes
Feb 12, 2022
bangerth
reviewed
Feb 14, 2022
| @@ -1549,6 +1549,18 @@ class Table<3, T> : public TableBase<3, T> | |||
| InputIterator entries, | |||
| const bool C_style_indexing = true); | |||
|
|
|||
| /** | |||
| * Reinitialize the object. Passes down to the base class | |||
| * by converting the arguments to the data type requested by the base class. | |||
There was a problem hiding this comment.
I'm coming late to this patch, but there is nothing to be converted in this function. Is this a copy-paste mistake, or am I just not understanding what you are referring to here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to be consistent with the constructor and
Table<2, T>::reinit()