Remove some unnecessary includes of grid_tools.h #13422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronbichler
force-pushed
the
remove_unneeded_headers
branch
from
6b786fc
to
3dabd9f
Compare
|
It's pretty interesting how many implicit include we have had before. Now it seems better (but I can't say for sure because we have too many test failures right now to find things reliably). |
kronbichler
force-pushed
the
remove_unneeded_headers
branch
from
3dabd9f
to
b081af1
Compare
|
I agree with this patch, but we should probably add a changelog entry to the "incompatibilities" for this. |
bangerth
approved these changes
Feb 22, 2022
|
OK if you add the changelog entry @tjhei suggests. I hope that we can eventually just do |
kronbichler
force-pushed
the
remove_unneeded_headers
branch
from
b89afa4
to
cdea6f7
Compare
|
I added a changelog file as suggested by @tjhei. |
This was referenced Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the fact that step-37 includes 626k lines of code once all headers are resolved as noted in #13420, this PR tries to avoid including
grid_tools.h, which involves a huge amount of boost code. This is possible as there is no reference to those functions in any code, probably a left-over from times where we actually had implementations or data structures using that code. Now we are down to 500k lines of code. More importantly, we more clearly communicate the dependencies, rather than pulling in almost all our code.